Messages in this thread | | | Date | Tue, 27 Aug 2019 09:27:44 +0930 | From | "Andrew Jeffery" <> | Subject | Re: [PATCH v2 4/4] dt-bindings/watchdog: Add access cs0 opti on for alt-boot |
| |
On Mon, 26 Aug 2019, at 20:17, Ivan Mikhaylov wrote: > The option for the ast2400/2500 to get access to CS0 at runtime. > > Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com> > --- > Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > index c5077a1f5cb3..023a9b578df6 100644 > --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > @@ -34,6 +34,13 @@ Optional properties: > engine is responsible for this. > > - aspeed,alt-boot: If property is present then boot from alternate > block. > + At alternate side 'access_cs0' sysfs file > provides:
Why are we talking about sysfs in the devicetree binding? This patch doesn't seem right to me.
Also if we're not supporting the aspeed,alt-boot property we should probably document it as deprecated rather than making it disappear, unless you're going to fix the systems that are using it.
Andrew
| |