| Date | Mon, 26 Aug 2019 14:40:02 +0200 | From | Boris Brezillon <> | Subject | Re: [RESEND PATCH v3 14/20] mtd: spi_nor: Add a ->setup() method |
| |
On Mon, 26 Aug 2019 12:08:58 +0000 <Tudor.Ambarus@microchip.com> wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com> > > nor->params.setup() configures the SPI NOR memory. Useful for SPI NOR > flashes that have peculiarities to the SPI NOR standard, e.g. > different opcodes, specific address calculation, page size, etc. > Right now the only user will be the S3AN chips, but other > manufacturers can implement it if needed. > > Move spi_nor_setup() related code in order to avoid a forward > declaration to spi_nor_default_setup(). > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Nitpick: R-bs should normally be placed after your SoB.
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > ---
|