lkml.org 
[lkml]   [2019]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation
From
Date


On 8/26/19 3:46 PM, Sourabh Jain wrote:
>
>
> On 8/26/19 3:29 PM, Hari Bathini wrote:
>>
>>
>> On 10/08/19 11:29 PM, Sourabh Jain wrote:
>>> Add a sys interface to allow querying the memory reserved by
>>> fadump for saving the crash dump.
>>>
>>> Add an ABI doc entry for new sysfs interface.
>>> - /sys/kernel/fadump_mem_reserved
>>>
>>> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
>>> ---
>>> Changelog:
>>> v1 -> v2:
>>> - Added ABI doc for new sysfs interface.
>>>
>>> v2 -> v3:
>>> - Updated the ABI documentation.
>>> ---
>>>
>>> Documentation/ABI/testing/sysfs-kernel-fadump | 6 ++++++
>>
>> Shouldn't this be Documentation/ABI/testing/sysfs-kernel-fadump_mem_reserved?

How about documenting fadump_mem_reserved and other sysfs attributes suggested
by you in a single file Documentation/ABI/testing/sysfs-kernel-fadump?

>>
>>> +++ b/Documentation/ABI/testing/sysfs-kernel-fadump
>>> @@ -0,0 +1,6 @@
>>> +What: /sys/kernel/fadump_mem_reserved
>>> +Date: August 2019
>>> +Contact: linuxppc-dev@lists.ozlabs.org
>>> +Description: read only
>>> + Provide information about the amount of memory
>>> + reserved by fadump to save the crash dump.
>>
>> Split this up into a separate patch and have ABI documentation for
>> fadump_reserved & fadump_registered as well..

- Sourabh Jain

\
 
 \ /
  Last update: 2019-08-26 12:45    [W:0.068 / U:28.208 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site