Messages in this thread Patch in this message | | | From | Pingfan Liu <> | Subject | [PATCHv2 1/4] x86/apic: correct the ENO in generic_processor_info() | Date | Tue, 27 Aug 2019 11:02:20 +0800 |
| |
When capped by nr_cpu_ids, the current code return -EINVAL or -ENODEV. It is better to return -EINVAL for both cases.
Signed-off-by: Pingfan Liu <kernelfans@gmail.com> To: Thomas Gleixner <tglx@linutronix.de> To: Andy Lutomirski <luto@kernel.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Peter Zijlstra <peterz@infradead.org> To: x86@kernel.org Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Qian Cai <cai@lca.pw> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Daniel Drake <drake@endlessm.com> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Eric Biederman <ebiederm@xmission.com> Cc: linux-kernel@vger.kernel.org Cc: Dave Young <dyoung@redhat.com> Cc: Baoquan He <bhe@redhat.com> Cc: kexec@lists.infradead.org --- arch/x86/kernel/apic/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index f529136..f4f603a 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2346,7 +2346,7 @@ int generic_processor_info(int apicid, int version) " Processor %d/0x%x ignored.\n", max, thiscpu, apicid); disabled_cpus++; - return -ENODEV; + return -EINVAL; } if (num_processors >= nr_cpu_ids) { -- 2.7.5
| |