lkml.org 
[lkml]   [2019]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/3] vmstats/vmevents flushing
On Fri, 23 Aug 2019 00:33:51 +0000 Roman Gushchin <guro@fb.com> wrote:

> On Thu, Aug 22, 2019 at 04:27:09PM -0700, Andrew Morton wrote:
> > On Mon, 19 Aug 2019 16:00:51 -0700 Roman Gushchin <guro@fb.com> wrote:
> >
> > > v3:
> > > 1) rearranged patches [2/3] and [3/3] to make [1/2] and [2/2] suitable
> > > for stable backporting
> > >
> > > v2:
> > > 1) fixed !CONFIG_MEMCG_KMEM build by moving memcg_flush_percpu_vmstats()
> > > and memcg_flush_percpu_vmevents() out of CONFIG_MEMCG_KMEM
> > > 2) merged add-comments-to-slab-enums-definition patch in
> > >
> > > Thanks!
> > >
> > > Roman Gushchin (3):
> > > mm: memcontrol: flush percpu vmstats before releasing memcg
> > > mm: memcontrol: flush percpu vmevents before releasing memcg
> > > mm: memcontrol: flush percpu slab vmstats on kmem offlining
> > >
> >
> > Can you please explain why the first two patches were cc:stable but not
> > the third?
> >
> >
>
> Because [1] and [2] are fixing commit 42a300353577 ("mm: memcontrol: fix
> recursive statistics correctness & scalabilty"), which has been merged into 5.2.
>
> And [3] fixes commit fb2f2b0adb98 ("mm: memcg/slab: reparent memcg kmem_caches
> on cgroup removal"), which is in not yet released 5.3, so stable backport isn't
> required.

OK, thanks. Patches 1 & 2 are good to go but I don't think that #3 has
had suitable review and I have a note here that Michal has concerns
with it.

\
 
 \ /
  Last update: 2019-08-24 22:54    [W:0.036 / U:2.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site