lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 112/135] net: sched: sch_taprio: fix memleak in error path for sched list parse
    Date
    From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

    [ Upstream commit 51650d33b2771acd505068da669cf85cffac369a ]

    In error case, all entries should be freed from the sched list
    before deleting it. For simplicity use rcu way.

    Fixes: 5a781ccbd19e46 ("tc: Add support for configuring the taprio scheduler")
    Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
    Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/sch_taprio.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
    index 9ecfb8f5902a4..8be89aa52b6e8 100644
    --- a/net/sched/sch_taprio.c
    +++ b/net/sched/sch_taprio.c
    @@ -849,7 +849,8 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt,
    spin_unlock_bh(qdisc_lock(sch));

    free_sched:
    - kfree(new_admin);
    + if (new_admin)
    + call_rcu(&new_admin->rcu, taprio_free_sched_cb);

    return err;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-08-22 19:26    [W:4.452 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site