lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 082/135] RDMA/hns: Fix error return code in hns_roce_v1_rsv_lp_qp()
    Date
    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit 020fb3bebc224dfe9353a56ecbe2d5fac499dffc ]

    Fix to return error code -ENOMEM from the rdma_zalloc_drv_obj() error
    handling case instead of 0, as done elsewhere in this function.

    Fixes: e8ac9389f0d7 ("RDMA: Fix allocation failure on pointer pd")
    Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core")
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
    Link: https://lore.kernel.org/r/20190801012725.150493-1-weiyongjun1@huawei.com
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
    index e068a02122f5e..9496c69fff3a2 100644
    --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
    @@ -745,8 +745,10 @@ static int hns_roce_v1_rsv_lp_qp(struct hns_roce_dev *hr_dev)

    ibdev = &hr_dev->ib_dev;
    pd = rdma_zalloc_drv_obj(ibdev, ib_pd);
    - if (!pd)
    + if (!pd) {
    + ret = -ENOMEM;
    goto alloc_mem_failed;
    + }

    pd->device = ibdev;
    ret = hns_roce_alloc_pd(pd, NULL);
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-08-22 19:26    [W:4.610 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site