Messages in this thread | | | From | Rob Herring <> | Date | Thu, 22 Aug 2019 20:52:47 -0500 | Subject | Re: [PATCH] drm/panfrost: Add missing check for pfdev->regulator |
| |
On Thu, Aug 22, 2019 at 4:32 AM Steven Price <steven.price@arm.com> wrote: > > When modifying panfrost_devfreq_target() to support a device without a > regulator defined I missed the check on the error path. Let's add it. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Fixes: e21dd290881b ("drm/panfrost: Enable devfreq to work without regulator") > Signed-off-by: Steven Price <steven.price@arm.com> > --- > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
Looks fine to me, but seems to be delayed getting to the list and patchwork. I'm guessing you're not subscribed to dri-devel because all your patches seem to get delayed.
Rob
> > diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > index 710d903f8e0d..a1f5fa6a742a 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c > +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > @@ -53,8 +53,10 @@ static int panfrost_devfreq_target(struct device *dev, unsigned long *freq, > if (err) { > dev_err(dev, "Cannot set frequency %lu (%d)\n", target_rate, > err); > - regulator_set_voltage(pfdev->regulator, pfdev->devfreq.cur_volt, > - pfdev->devfreq.cur_volt); > + if (pfdev->regulator) > + regulator_set_voltage(pfdev->regulator, > + pfdev->devfreq.cur_volt, > + pfdev->devfreq.cur_volt); > return err; > } > > -- > 2.20.1 >
| |