Messages in this thread | | | From | Atish Patra <> | Subject | Re: [PATCH v4 3/3] RISC-V: Issue a tlb page flush if possible | Date | Thu, 22 Aug 2019 18:31:29 +0000 |
| |
On Thu, 2019-08-22 at 10:11 +0200, Christoph Hellwig wrote: > On Thu, Aug 22, 2019 at 12:51:51AM -0700, Atish Patra wrote: > > If tlbflush request is for page only, there is no need to do a > > complete local tlb shootdown. > > > > Just do a local tlb flush for the given address. > > Looks good, although I suspect in many cases even doing multiple > single-page sfence.vma calls might be cheaper than the global one. > > But I think that is worth a ѕeparate discussion, preferably with > actual > numbers. >
Yup. Finding a good threashold is always tricky without real benchmarks.
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for the review.
-- Regards, Atish
| |