Messages in this thread | | | Subject | Re: [PATCH v2] mt76: fix some checkpatch warnings | From | Joe Perches <> | Date | Wed, 21 Aug 2019 04:59:16 -0700 |
| |
On Wed, 2019-08-21 at 11:11 +0800, Ryder Lee wrote: > This fixes the following checkpatch warnings: > CHECK: Alignment should match open parenthesis > CHECK: No space is necessary after a cast > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > Changes since v2: remove false positive checkpatch warnings.
What were those?
> diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c [] > @@ -587,8 +589,8 @@ mt76_check_sta(struct mt76_dev *dev, struct sk_buff *skb) > } > > if (ieee80211_has_morefrags(hdr->frame_control) || > - !(ieee80211_is_mgmt(hdr->frame_control) || > - ieee80211_is_data(hdr->frame_control))) > + !(ieee80211_is_mgmt(hdr->frame_control) || > + ieee80211_is_data(hdr->frame_control)))
Poor alignment here.
This should be:
if (ieee80211_has_morefrags(hdr->frame_control) || !(ieee80211_is_mgmt(hdr->frame_control) || ieee80211_is_data(hdr->frame_control)))
| |