Messages in this thread | | | Subject | Re: [PATCH v2 2/3] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE | From | Philipp Zabel <> | Date | Tue, 20 Aug 2019 17:42:49 +0200 |
| |
On Tue, 2019-08-20 at 11:40 +0200, Ricardo Ribalda Delgado wrote: > New control to pass to userspace the width/height of a pixel. Which is > needed for calibration and lens selection. > > Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org> > --- > Documentation/media/uapi/v4l/ext-ctrls-camera.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst > index 51c1d5c9eb00..b43047d4e7a1 100644 > --- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst > +++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst > @@ -510,6 +510,14 @@ enum v4l2_scene_mode - > value down. A value of zero stops the motion if one is in progress > and has no effect otherwise. > > +``V4L2_CID_UNIT_CELL_SIZE (struct)`` > + This control returns the unit cell size in nanometres. The struct provides > + the width and the height in separated fields to take into consideration > + asymmetric pixels and/or hardware binning. > + The unit cell consist on the whole area of the pixel, sensitive and > + non-sensitive.
"consists of", otherwise this looks unambiguous to me.
I'm not sure if it is required to add a table for struct v4l2_area, similarly to the other compound controls.
> + This control is required for automatic calibration sensors/cameras. > + > .. [#f1] > This control may be changed to a menu control in the future, if more > options are required.
regards Philipp
| |