lkml.org 
[lkml]   [2019]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 13/27] iio: adc: max9611: Fix temperature reading in probe
    Date
    From: Jacopo Mondi <jacopo+renesas@jmondi.org>

    [ Upstream commit b9ddd5091160793ee9fac10da765cf3f53d2aaf0 ]

    The max9611 driver reads the die temperature at probe time to validate
    the communication channel. Use the actual read value to perform the test
    instead of the read function return value, which was mistakenly used so
    far.

    The temperature reading test was only successful because the 0 return
    value is in the range of supported temperatures.

    Fixes: 69780a3bbc0b ("iio: adc: Add Maxim max9611 ADC driver")
    Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/adc/max9611.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c
    index ce9af43fa2de7..49c1956e6a674 100644
    --- a/drivers/iio/adc/max9611.c
    +++ b/drivers/iio/adc/max9611.c
    @@ -483,7 +483,7 @@ static int max9611_init(struct max9611_dev *max9611)
    if (ret)
    return ret;

    - regval = ret & MAX9611_TEMP_MASK;
    + regval &= MAX9611_TEMP_MASK;

    if ((regval > MAX9611_TEMP_MAX_POS &&
    regval < MAX9611_TEMP_MIN_NEG) ||
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-08-20 15:56    [W:4.184 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site