Messages in this thread | | | Subject | Re: [PATCH v2 05/12] powerpc/mm: rework io-workaround invocation. | From | Benjamin Herrenschmidt <> | Date | Wed, 21 Aug 2019 10:42:27 +1000 |
| |
On Wed, 2019-08-21 at 00:28 +0200, Christoph Hellwig wrote: > On Tue, Aug 20, 2019 at 02:07:13PM +0000, Christophe Leroy wrote: > > ppc_md.ioremap() is only used for I/O workaround on CELL platform, > > so indirect function call can be avoided. > > > > This patch reworks the io-workaround and ioremap() functions to > > use the global 'io_workaround_inited' flag for the activation > > of io-workaround. > > > > When CONFIG_PPC_IO_WORKAROUNDS or CONFIG_PPC_INDIRECT_MMIO are not > > selected, the I/O workaround ioremap() voids and the global flag is > > not used. > > Note that CONFIG_PPC_IO_WORKAROUNDS is only selected by a specific cell > config, and CONFIG_PPC_INDIRECT_MMIO is always selected by cell, so > I think we can make CONFIG_PPC_IO_WORKAROUNDS depend on > CONFIG_PPC_INDIRECT_MMIO
Or we can deprecate that old platform... not sure anybody uses it anymore (if anybody ever did).
Cheers, ben.
| |