lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 062/223] crypto: asymmetric_keys - select CRYPTO_HASH where needed
    Date
    [ Upstream commit 90acc0653d2bee203174e66d519fbaaa513502de ]

    Build testing with some core crypto options disabled revealed
    a few modules that are missing CRYPTO_HASH:

    crypto/asymmetric_keys/x509_public_key.o: In function `x509_get_sig_params':
    x509_public_key.c:(.text+0x4c7): undefined reference to `crypto_alloc_shash'
    x509_public_key.c:(.text+0x5e5): undefined reference to `crypto_shash_digest'
    crypto/asymmetric_keys/pkcs7_verify.o: In function `pkcs7_digest.isra.0':
    pkcs7_verify.c:(.text+0xab): undefined reference to `crypto_alloc_shash'
    pkcs7_verify.c:(.text+0x1b2): undefined reference to `crypto_shash_digest'
    pkcs7_verify.c:(.text+0x3c1): undefined reference to `crypto_shash_update'
    pkcs7_verify.c:(.text+0x411): undefined reference to `crypto_shash_finup'

    This normally doesn't show up in randconfig tests because there is
    a large number of other options that select CRYPTO_HASH.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    crypto/asymmetric_keys/Kconfig | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
    index 331f6baf2df8..13f3de68b479 100644
    --- a/crypto/asymmetric_keys/Kconfig
    +++ b/crypto/asymmetric_keys/Kconfig
    @@ -14,6 +14,7 @@ config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
    select MPILIB
    select CRYPTO_HASH_INFO
    select CRYPTO_AKCIPHER
    + select CRYPTO_HASH
    help
    This option provides support for asymmetric public key type handling.
    If signature generation and/or verification are to be used,
    @@ -33,6 +34,7 @@ config X509_CERTIFICATE_PARSER
    config PKCS7_MESSAGE_PARSER
    tristate "PKCS#7 message parser"
    depends on X509_CERTIFICATE_PARSER
    + select CRYPTO_HASH
    select ASN1
    select OID_REGISTRY
    help
    @@ -55,6 +57,7 @@ config SIGNED_PE_FILE_VERIFICATION
    bool "Support for PE file signature verification"
    depends on PKCS7_MESSAGE_PARSER=y
    depends on SYSTEM_DATA_VERIFICATION
    + select CRYPTO_HASH
    select ASN1
    select OID_REGISTRY
    help
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-02 12:10    [W:2.634 / U:0.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site