lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 021/223] media: staging: media: davinci_vpfe: - Fix for memory leak if decoder initialization fails.
    Date
    [ Upstream commit 6995a659101bd4effa41cebb067f9dc18d77520d ]

    Fix to avoid possible memory leak if the decoder initialization
    got failed.Free the allocated memory for file handle object
    before return in case decoder initialization fails.

    Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/davinci_vpfe/vpfe_video.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
    index 89dd6b989254..e0440807b4ed 100644
    --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
    +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
    @@ -423,6 +423,9 @@ static int vpfe_open(struct file *file)
    /* If decoder is not initialized. initialize it */
    if (!video->initialized && vpfe_update_pipe_state(video)) {
    mutex_unlock(&video->lock);
    + v4l2_fh_del(&handle->vfh);
    + v4l2_fh_exit(&handle->vfh);
    + kfree(handle);
    return -ENODEV;
    }
    /* Increment device users counter */
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-02 12:09    [W:6.684 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site