Messages in this thread | | | Date | Fri, 2 Aug 2019 13:47:12 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v4 0/8] recordmcount cleanups |
| |
On Wed, 31 Jul 2019 11:24:08 -0700 Matt Helsley <mhelsley@vmware.com> wrote:
> recordmcount presents unnecessary challenges to reviewers: > > It pretends to wrap access to the ELF file in > uread/uwrite/ulseek functions which aren't related > the way you might think (i.e. not the way read, write, > and lseek are releated to each other). > > It uses setjmp/longjmp to handle errors (and success) > during processing of the object files. This makes it > hard to review what functions are doing, how globals > change over time, etc. > > There are some kernel style nits. > > This series addresses all of those by removing un-helper functions, > unused parameters, and rewriting the error/success handling to > better resemble regular kernel C code. >
I applied these patches to my queue.
I pushed them to my repo on branch ftrace/core
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
But note, that this branch will rebase, probably on top of v5.3-rc3 when it comes out.
-- Steve
| |