lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 12/24] EDAC, ghes: Use standard kernel macros for page calculations
    From
    Date
    Hi Robert,

    On 24/06/2019 16:09, Robert Richter wrote:
    > Use standard macros for page calculations.
    >
    > Signed-off-by: Robert Richter <rrichter@marvell.com>
    > ---

    > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
    > index 786f1b32eee1..746083876b5f 100644
    > --- a/drivers/edac/ghes_edac.c
    > +++ b/drivers/edac/ghes_edac.c
    > @@ -311,8 +311,8 @@ void ghes_edac_report_mem_error(int sev, struct cper_sec_mem_err *mem_err)
    >
    > /* Error address */
    > if (mem_err->validation_bits & CPER_MEM_VALID_PA) {
    > - e->page_frame_number = mem_err->physical_addr >> PAGE_SHIFT;
    > - e->offset_in_page = mem_err->physical_addr & ~PAGE_MASK;
    > + e->page_frame_number = PHYS_PFN(mem_err->physical_addr);
    > + e->offset_in_page = offset_in_page(mem_err->physical_addr);
    > }
    >
    > /* Error grain */
    >


    After a shorter game of spot-the-difference:
    Reviewed-by: James Morse <james.morse@arm.com>

    Previously here:
    https://lore.kernel.org/linux-edac/e566fe1d-ed06-53bc-6827-f6dfa32ee485@arm.com/


    Please pick up tags when posting a new version.
    If you don't do this, its very difficult to convince people to spend time reviewing your
    series.


    Thanks,

    James

    \
     
     \ /
      Last update: 2019-08-02 19:05    [W:4.757 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site