Messages in this thread | | | Date | Fri, 2 Aug 2019 18:50:44 +0200 | From | Adrian Reber <> | Subject | Re: [PATCH v2 1/2] fork: extend clone3() to support CLONE_SET_TID |
| |
On Fri, Aug 02, 2019 at 03:52:49PM +0200, Christian Brauner wrote: > On Fri, Aug 02, 2019 at 03:46:11PM +0200, Oleg Nesterov wrote: > > On 08/02, Oleg Nesterov wrote: > > > > > > So Adrian, sorry for confusion, I think your patch is fine.
Good to know.
> > Yes... but do we really need the new CLONE_SET_TID ? > > > > set_tid == 0 has no effect, can't we simply check kargs->set_tid != 0 > > before ns_capable() ? > > Yeah, I agree that sounds much better and aligns with exit_signal.
Let me remove CLONE_SET_TID from the patch and I will try out idr_is_empty().
I will also address Dmitry's comment about accessing smaller parameter structs.
Adrian
| |