Messages in this thread | | | From | Arnaldo Carvalho de Melo <> | Date | Mon, 19 Aug 2019 15:50:54 -0300 | Subject | Re: [PATCH 1/2] perf cs-etm: Support sample flags 'insn' and 'insnlen' |
| |
Em Mon, Aug 19, 2019 at 12:08:26PM -0600, Mathieu Poirier escreveu: > On Thu, 15 Aug 2019 at 02:30, Leo Yan <leo.yan@linaro.org> wrote: > > > > The synthetic branch and instruction samples are missed to set > > instruction related info, thus perf tool fails to display samples with > > flags '-F,+insn,+insnlen'. > > > > CoreSight trace decoder has provided sufficient information to decide > > the instruction size based on the isa type: A64/A32 instruction are > > 32-bit size, but one exception is the T32 instruction size, which might > > be 32-bit or 16-bit. > > > > This patch handles for these cases and it reads the instruction values > > from DSO file; thus can support flags '-F,+insn,+insnlen'.
> The code seems to be correct. I have also tested this patch.
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Thanks, applied.
- Arnaldo
| |