lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/RFT v4 1/5] tpm: move tpm_buf code to include/linux/
On Tue, Aug 13, 2019 at 01:23:00PM +0530, Sumit Garg wrote:
> Move tpm_buf code to common include/linux/tpm.h header so that it can
> be reused via other subsystems like trusted keys etc.
>
> Also rename trusted keys TPM 1.x buffer implementation to tpm1_buf to
> avoid any compilation errors.
>
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

A question: did you try to do this as mechanically as you ever could
or did you do any other code changes? I did go through it but it is
possible that I missed something.

In this type of changes it is mandatory be extra strict on not doing
anything extra (the rename you would was not of course extra because
it was necessary to do).

/Jarkko

\
 
 \ /
  Last update: 2019-08-19 19:15    [W:0.148 / U:4.704 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site