lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] PTP: introduce new versions of IOCTLs
From
Date
On Mon, 2019-08-19 at 08:43 -0700, Richard Cochran wrote:
> On Sun, Aug 18, 2019 at 03:07:18PM -0700, Joe Perches wrote:
> > Also the original patch deletes 2 case entries for
> > PTP_PIN_GETFUNC and PTP_PIN_SETFUNC and converts them to
> > PTP_PIN_GETFUNC2 and PTP_PIN_SETFUNC2 but still uses tests
> > for the deleted case label entries making part of the case
> > code block unreachable.
> >
> > That's at least a defect:
> >
> > - case PTP_PIN_GETFUNC:
> > + case PTP_PIN_GETFUNC2:
> >
> > and
> >
> > - case PTP_PIN_SETFUNC:
> > + case PTP_PIN_SETFUNC2:
>
> Good catch. Felipe, please fix that!
>
> (Regarding Joe's memset suggestion, I'll leave that to your discretion.)

Not just how declarations are done or memset.

Minimizing unnecessary stack consumption is generally good.


\
 
 \ /
  Last update: 2019-08-19 17:59    [W:0.096 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site