Messages in this thread | | | From | Tomasz Figa <> | Date | Mon, 19 Aug 2019 13:17:04 +0900 | Subject | Re: [PATCH] staging: media: hantro: Remove call to memset after dma_alloc_coherent |
| |
Hi Hans,
On Thu, Jul 25, 2019 at 8:50 PM Boris Brezillon <boris.brezillon@collabora.com> wrote: > > On Thu, 25 Jul 2019 08:36:02 +0530 > Hariprasad Kelam <hariprasad.kelam@gmail.com> wrote: > > > fix below issue reported by coccicheck > > /drivers/staging/media/hantro/hantro_vp8.c:149:16-34: WARNING: > > dma_alloc_coherent use in aux_buf -> cpu already zeroes out memory, so > > memset is not needed > > > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > > > --- > > drivers/staging/media/hantro/hantro_vp8.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/staging/media/hantro/hantro_vp8.c b/drivers/staging/media/hantro/hantro_vp8.c > > index 66c4533..363ddda 100644 > > --- a/drivers/staging/media/hantro/hantro_vp8.c > > +++ b/drivers/staging/media/hantro/hantro_vp8.c > > @@ -151,8 +151,6 @@ int hantro_vp8_dec_init(struct hantro_ctx *ctx) > > if (!aux_buf->cpu) > > return -ENOMEM; > > > > - memset(aux_buf->cpu, 0, aux_buf->size); > > - > > /* > > * Allocate probability table buffer, > > * total 1208 bytes, 4K page is far enough. >
Is this something you will pick to your tree?
Best regards, Tomasz
| |