lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor
    From
    Date
    On 26/07/2019 00:18, Amit Kucheria wrote:
    > There are two fields - id and hw_id - to track what sensor an action was
    > to performed on. This was because the sensors connected to a TSENS IP
    > might not be contiguous i.e. 1, 2, 4, 5 with 3 being skipped.
    >
    > This causes confusion in the code which uses hw_id sometimes and id
    > other times (tsens_get_temp, tsens_get_trend).
    >
    > Switch to only using the hw_id field to track the physical ID of the
    > sensor. When we iterate through all the sensors connected to an IP
    > block, we use an index i to loop through the list of sensors, and then
    > return the actual hw_id that is registered on that index.
    >
    > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

    Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>




    --
    <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

    Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
    <http://twitter.com/#!/linaroorg> Twitter |
    <http://www.linaro.org/linaro-blog/> Blog

    \
     
     \ /
      Last update: 2019-08-19 13:56    [W:4.113 / U:1.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site