lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration
Hi!

> Allow the full scale current to be configured at init.
> Valid rangles are 5mA->29.8mA.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> @@ -121,6 +125,7 @@ struct lm3532_als_data {
> * @mode - Mode of the LED string
> * @ctrl_brt_pointer - Zone target register that controls the sink
> * @num_leds - Number of LED strings are supported in this array
> + * @full_scale_current - The full-scale current setting for the current sink.
> * @led_strings - The LED strings supported in this array
> * @label - LED label
> */
> @@ -130,8 +135,9 @@ struct lm3532_led {
>
> int control_bank;
> int mode;
> - int ctrl_brt_pointer;
> int num_leds;
> + int ctrl_brt_pointer;
> + int full_scale_current;
> u32 led_strings[LM3532_MAX_CONTROL_BANKS];
> char label[LED_MAX_NAME_SIZE];
> };

No need to move ctrl_brt_pointer... to keep order consistent with docs.

> + fs_current_val = led->full_scale_current - LM3532_FS_CURR_MIN /
> + LM3532_FS_CURR_STEP;

The computation is wrong ... needs () AFAICT.

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-08-19 12:57    [W:0.091 / U:0.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site