lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2 v2] mm/zsmalloc.c: Migration can leave pages in ZS_EMPTY indefinitely
    On (08/09/19 11:17), Henry Burns wrote:
    > In zs_page_migrate() we call putback_zspage() after we have finished
    > migrating all pages in this zspage. However, the return value is ignored.
    > If a zs_free() races in between zs_page_isolate() and zs_page_migrate(),
    > freeing the last object in the zspage, putback_zspage() will leave the page
    > in ZS_EMPTY for potentially an unbounded amount of time.
    >
    > To fix this, we need to do the same thing as zs_page_putback() does:
    > schedule free_work to occur. To avoid duplicated code, move the
    > sequence to a new putback_zspage_deferred() function which both
    > zs_page_migrate() and zs_page_putback() call.
    >
    > Fixes: 48b4800a1c6a ("zsmalloc: page migration support")
    > Signed-off-by: Henry Burns <henryburns@google.com>

    Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

    + Andrew

    -ss

    \
     
     \ /
      Last update: 2019-08-20 04:53    [W:2.452 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site