lkml.org 
[lkml]   [2019]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/10] mm: turn migrate_vma upside down
Date
On Sat, Aug 17, 2019 at 01:31:28PM +0200, Christoph Hellwig wrote:
> On Fri, Aug 16, 2019 at 05:11:07PM +0000, Jason Gunthorpe wrote:
> > - if (args->cpages)
> > - migrate_vma_prepare(args);
> > - if (args->cpages)
> > - migrate_vma_unmap(args);
> > + if (!args->cpages)
> > + return 0;
> > +
> > + migrate_vma_prepare(args);
> > + migrate_vma_unmap(args);
>
> I don't think this is ok. Both migrate_vma_prepare and migrate_vma_unmap
> can reduce args->cpages, including possibly to 0.

Oh, yes, that was far too hasty on my part, I had assumed collect set
the cpages. Thank you for checking

Jason

\
 
 \ /
  Last update: 2019-08-17 14:51    [W:0.037 / U:11.900 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site