lkml.org 
[lkml]   [2019]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/10] mm: turn migrate_vma upside down
On Fri, Aug 16, 2019 at 05:11:07PM +0000, Jason Gunthorpe wrote:
> - if (args->cpages)
> - migrate_vma_prepare(args);
> - if (args->cpages)
> - migrate_vma_unmap(args);
> + if (!args->cpages)
> + return 0;
> +
> + migrate_vma_prepare(args);
> + migrate_vma_unmap(args);

I don't think this is ok. Both migrate_vma_prepare and migrate_vma_unmap
can reduce args->cpages, including possibly to 0.

\
 
 \ /
  Last update: 2019-08-17 13:32    [W:0.055 / U:7.204 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site