Messages in this thread | | | Date | Fri, 16 Aug 2019 19:59:42 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 6/6] arm64: document the choice of page attributes for pgprot_dmacoherent |
| |
On Fri, Aug 16, 2019 at 06:31:18PM +0100, Will Deacon wrote: > Mind if I tweak the second sentence to be: > > This is different from "Device-nGnR[nE]" memory which is intended for MMIO > and thus forbids speculation, preserves access size, requires strict > alignment and can also force write responses to come from the endpoint. > > ? It's a small change, but it better fits with the arm64 terminology > ("strongly ordered" is no longer used in the architecture). > > If you're happy with that, I can make the change and queue this patch > for 5.4.
I'm fine with the change, but you really need this series as base, as there is no pgprot_dmacoherent before the series. So I think I'll have to queue it up if we want it for 5.4, and I'll need a few more reviews for the other patches in this series first.
| |