Messages in this thread | | | Subject | Re: [PATCH] sched/fair: don't assign runtime for throttled cfs_rq | From | Valentin Schneider <> | Date | Fri, 16 Aug 2019 18:19:41 +0100 |
| |
On 16/08/2019 16:39, Liangyan wrote: > Thanks for the feedback. > Add some debug prints and get below log. It seems that pick_next_task_fair throttle the cfs_rq first, then call put_prev_entity to assign runtime to this cfs_rq. > [...] > > Regarding the suggested change, i’m not sure whether it is ok to skip the runtime account for curr task. >
Yeah it's probably pretty stupid. IIRC throttled cfs_rq means frozen rq_clock, so any subsequent call to update_curr() on a throttled cfs_rq should lead to an early bailout anyway due to delta_exec <= 0.
| |