Messages in this thread | | | Subject | Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules | From | Joe Lawrence <> | Date | Fri, 16 Aug 2019 08:43:37 -0400 |
| |
On 8/16/19 4:19 AM, Miroslav Benes wrote: > Hi, > >> I cleaned up the build system, and pushed it based on my >> kbuild tree. >> >> Please see: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git >> klp-cleanup > > This indeed looks much simpler and cleaner (as far as I can judge with my > limited kbuild knowledge). We just need to remove MODULE_INFO(livepatch, > "Y") from lib/livepatch/test_klp_convert_mod_a.c to make it compile and > work (test_klp_convert_mod_a is not a livepatch module, it is just a dummy > module which is then livepatched by lib/livepatch/test_klp_convert1.c). >
Yeah, Masahiro this is great, thanks for reworking this!
I did tweak one module like Miroslav mentioned and I think a few of the newly generated files need to be cleaned up as part of "make clean", but all said, this is a nice improvement.
Are you targeting the next merge window for your kbuild branch? (This appears to be what the klp-cleanup branch was based on.)
Thanks,
-- Joe
| |