lkml.org 
[lkml]   [2019]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v4 11/14] net: phy: adin: implement Energy Detect Powerdown mode
    Date
    On Wed, 2019-08-14 at 10:57 -0700, Florian Fainelli wrote:
    > [External]
    >
    >
    >
    > On 8/12/2019 4:23 AM, Alexandru Ardelean wrote:
    > > The ADIN PHYs support Energy Detect Powerdown mode, which puts the PHY into
    > > a low power mode when there is no signal on the wire (typically cable
    > > unplugged).
    > > This behavior is enabled by default, but can be disabled via device
    > > property.
    >
    > We could consider adding a PHY tunable, having this as a Device Tree
    > property amounts to putting a policy inside DT, which is frowned upon.

    That would be interesting actually, and I would also prefer it over static DT.
    Maybe for this patch, I'll just enable EDPD by default and see about a tuna option.

    >
    > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
    >
    > Other than that, the code looks fine:
    >
    > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    \
     
     \ /
      Last update: 2019-08-16 08:14    [W:2.808 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site