lkml.org 
[lkml]   [2019]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] FS: timerfd: [Trimmed unreadable long subject line ]
Arul,

On Fri, 16 Aug 2019, arul.jeniston@gmail.com wrote:

Please write the subject as a short precise sentence which fits into 70
characters and put the long explanation into the body, i.e. here.

See Documentation/process/submitting-patches.rst

> From: ARUL JENISTON MC <arul.jeniston@gmail.com>

This lacks a Signed-off-by

> ---
> fs/timerfd.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/fs/timerfd.c b/fs/timerfd.c
> index 6a6fc8aa1de7..f5094e070e9a 100644
> --- a/fs/timerfd.c
> +++ b/fs/timerfd.c
> @@ -284,8 +284,16 @@ static ssize_t timerfd_read(struct file *file, char __user *buf, size_t count,
> &ctx->t.alarm, ctx->tintv) - 1;
> alarm_restart(&ctx->t.alarm);
> } else {
> - ticks += hrtimer_forward_now(&ctx->t.tmr,
> - ctx->tintv) - 1;
> + u64 nooftimeo = hrtimer_forward_now(&ctx->t.tmr,
> + ctx->tintv);
> + /*
> + * ticks shouldn't become zero at this point.
> + * Ignore if hrtimer_forward_now returns 0
> + * due to larger backward time drift.
> + */

What? Backward time drift? Can you please explain how this would happen?

> + if (likely(nooftimeo)) {
> + ticks += nooftimeo - 1;
> + }

Pointless brackets.

Thanks,

tglx

\
 
 \ /
  Last update: 2019-08-16 11:06    [W:0.045 / U:26.928 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site