[lkml]   [2019]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] gpio: pl061: Fix the issue failed to register the ACPI interruption
Hi Linus,

On 2019/8/14 17:04, Linus Walleij wrote:
> Hi Wei,
> thanks for your patch!
> This doesn't apply for my "devel" branch, can you rebase
> on this:
> We have moved some ACPI headers around recently.

Thanks to review!
I just sent out the v2 based on that.

> On Mon, Aug 12, 2019 at 1:28 PM Wei Xu <> wrote:
>> Invoke acpi_gpiochip_request_interrupts after the acpi data has been
>> attached to the pl061 acpi node to register interruption.
> Makes sense.
>> Fixes: 04ce935c6b2a ("gpio: pl061: Pass irqchip when adding gpiochip")
> I doubt this is a regression since I haven't seen anyone use this
> gpiochip with ACPI before.
> Please rename the patch "gpio: pl061: Add ACPI support" unless
> you can convince me it worked without changes before.

In the v2, I attached the log on QEMU v3.0.0 and Linux kernel v5.2.0-rc7
the pl061 driver can register ACPI interruption.
Based on that, I did not rename the patch but I am OK to rename it if
you have
any doubt.

> Please include some ACPI people on review of this. From
> M: "Rafael J. Wysocki" <>
> M: Len Brown <>
> L:
> I would also include Andy Shevchenko and Mika Westerberg for
> the GPIO aspects.
Copied to all of them in the v2.

Best Regards,

> Thanks!
> Linus Walleij
> .

 \ /
  Last update: 2019-08-16 10:42    [W:0.040 / U:21.836 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site