lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v10 5/6] usb:cdns3 Add Cadence USB3 DRD Driver
    Date

    Hi,

    Roger Quadros <rogerq@ti.com> writes:

    > On 21/07/2019 21:32, Pawel Laszczak wrote:
    >> This patch introduce new Cadence USBSS DRD driver to Linux kernel.
    >>
    >> The Cadence USBSS DRD Controller is a highly configurable IP Core which
    >> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
    >> Host Only (XHCI)configurations.
    >>
    >> The current driver has been validated with FPGA platform. We have
    >> support for PCIe bus, which is used on FPGA prototyping.
    >>
    >> The host side of USBSS-DRD controller is compliant with XHCI
    >> specification, so it works with standard XHCI Linux driver.
    >>
    >> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
    >> ---
    >> drivers/usb/Kconfig | 2 +
    >> drivers/usb/Makefile | 2 +
    >> drivers/usb/cdns3/Kconfig | 46 +
    >> drivers/usb/cdns3/Makefile | 17 +
    >> drivers/usb/cdns3/cdns3-pci-wrap.c | 203 +++
    >> drivers/usb/cdns3/core.c | 554 +++++++
    >> drivers/usb/cdns3/core.h | 109 ++
    >> drivers/usb/cdns3/debug.h | 171 ++
    >> drivers/usb/cdns3/debugfs.c | 87 ++
    >> drivers/usb/cdns3/drd.c | 390 +++++
    >> drivers/usb/cdns3/drd.h | 166 ++
    >> drivers/usb/cdns3/ep0.c | 914 +++++++++++
    >> drivers/usb/cdns3/gadget-export.h | 28 +
    >> drivers/usb/cdns3/gadget.c | 2338 ++++++++++++++++++++++++++++
    >> drivers/usb/cdns3/gadget.h | 1321 ++++++++++++++++
    >> drivers/usb/cdns3/host-export.h | 28 +
    >> drivers/usb/cdns3/host.c | 71 +
    >> drivers/usb/cdns3/trace.c | 11 +
    >> drivers/usb/cdns3/trace.h | 493 ++++++
    >> 19 files changed, 6951 insertions(+)
    >> create mode 100644 drivers/usb/cdns3/Kconfig
    >> create mode 100644 drivers/usb/cdns3/Makefile
    >> create mode 100644 drivers/usb/cdns3/cdns3-pci-wrap.c
    >> create mode 100644 drivers/usb/cdns3/core.c
    >> create mode 100644 drivers/usb/cdns3/core.h
    >> create mode 100644 drivers/usb/cdns3/debug.h
    >> create mode 100644 drivers/usb/cdns3/debugfs.c
    >> create mode 100644 drivers/usb/cdns3/drd.c
    >> create mode 100644 drivers/usb/cdns3/drd.h
    >> create mode 100644 drivers/usb/cdns3/ep0.c
    >> create mode 100644 drivers/usb/cdns3/gadget-export.h
    >> create mode 100644 drivers/usb/cdns3/gadget.c
    >> create mode 100644 drivers/usb/cdns3/gadget.h
    >> create mode 100644 drivers/usb/cdns3/host-export.h
    >> create mode 100644 drivers/usb/cdns3/host.c
    >> create mode 100644 drivers/usb/cdns3/trace.c
    >> create mode 100644 drivers/usb/cdns3/trace.h
    >>
    >
    > <snip>
    >
    > It is getting really hard to review this patch as it is so large.
    > I would still suggest to split host/gadget/drd if possible.
    > Felipe, any objections?

    Maybe you guys can do a few rounds off-list then?

    --
    balbi

    \
     
     \ /
      Last update: 2019-08-15 08:14    [W:3.668 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site