| Date | Thu, 15 Aug 2019 11:14:24 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 06/22] watchdog: ziirave_wdt: Simplify ziirave_firm_write_pkt() |
| |
On Mon, Aug 12, 2019 at 01:08:50PM -0700, Andrey Smirnov wrote: > There no reason why ziirave_firm_write_pkt() has to take firmware > data via 'struct ihex_binrec' and it can just take address, data pointer > and data length as individual arguments. Make this change to allow us > to drastically simplify handling page crossing case by removing all of > the extra code required to split 'struct ihex_binrec' into two. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Rick Ramstetter <rick@anteaterllc.com> > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
|