lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] PCI: pci-hyperv: fix build errors on non-SYSFS config
    From
    Date
    On 8/15/19 3:47 AM, Lorenzo Pieralisi wrote:
    > On Fri, Jul 12, 2019 at 08:53:19AM -0700, Randy Dunlap wrote:
    >> From: Randy Dunlap <rdunlap@infradead.org>
    >>
    >> Fix build errors when building almost-allmodconfig but with SYSFS
    >> not set (not enabled). Fixes these build errors:
    >>
    >> ERROR: "pci_destroy_slot" [drivers/pci/controller/pci-hyperv.ko] undefined!
    >> ERROR: "pci_create_slot" [drivers/pci/controller/pci-hyperv.ko] undefined!
    >>
    >> drivers/pci/slot.o is only built when SYSFS is enabled, so
    >> pci-hyperv.o has an implicit dependency on SYSFS.
    >> Make that explicit.
    >>
    >> Also, depending on X86 && X86_64 is not needed, so just change that
    >> to depend on X86_64.
    >>
    >> Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot
    >> information")
    >
    > Fixed line break on Fixes tag, FYI.

    Thanks.

    >
    >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    >> Cc: Matthew Wilcox <willy@infradead.org>
    >> Cc: Jake Oshins <jakeo@microsoft.com>
    >> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
    >> Cc: Haiyang Zhang <haiyangz@microsoft.com>
    >> Cc: Stephen Hemminger <sthemmin@microsoft.com>
    >> Cc: Stephen Hemminger <stephen@networkplumber.org>
    >> Cc: Sasha Levin <sashal@kernel.org>
    >> Cc: Bjorn Helgaas <bhelgaas@google.com>
    >> Cc: linux-pci@vger.kernel.org
    >> Cc: linux-hyperv@vger.kernel.org
    >> Cc: Dexuan Cui <decui@microsoft.com>
    >> ---
    >> v3: corrected Fixes: tag [Dexuan Cui <decui@microsoft.com>]
    >> This is the Microsoft-preferred version of the patch.
    >>
    >> drivers/pci/Kconfig | 2 +-
    >> 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Applied to pci/hv for v5.4.
    >
    > Thanks,
    > Lorenzo
    >
    >> --- lnx-52.orig/drivers/pci/Kconfig
    >> +++ lnx-52/drivers/pci/Kconfig
    >> @@ -181,7 +181,7 @@ config PCI_LABEL
    >>
    >> config PCI_HYPERV
    >> tristate "Hyper-V PCI Frontend"
    >> - depends on X86 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && X86_64
    >> + depends on X86_64 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && SYSFS
    >> help
    >> The PCI device frontend driver allows the kernel to import arbitrary
    >> PCI devices from a PCI backend to support PCI driver domains.
    >>
    >>


    --
    ~Randy

    \
     
     \ /
      Last update: 2019-08-15 17:23    [W:3.066 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site