lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 07/10] iommu: Print default domain type on boot
From
Date
Hi,

On 8/14/19 9:38 PM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Introduce a subsys_initcall for IOMMU code and use it to
> print the default domain type at boot.
>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/iommu.c | 30 +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index e1feb4061b8b..233bc22b487e 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -93,12 +93,40 @@ struct iommu_group_attribute iommu_group_attr_##_name = \
> static LIST_HEAD(iommu_device_list);
> static DEFINE_SPINLOCK(iommu_device_lock);
>
> +/*
> + * Use a function instead of an array here because the domain-type is a
> + * bit-field, so an array would waste memory.
> + */
> +static const char *iommu_domain_type_str(unsigned int t)
> +{
> + switch (t) {
> + case IOMMU_DOMAIN_BLOCKED:
> + return "Blocked";
> + case IOMMU_DOMAIN_IDENTITY:
> + return "Passthrough";
> + case IOMMU_DOMAIN_UNMANAGED:
> + return "Unmanaged";
> + case IOMMU_DOMAIN_DMA:
> + return "Translated";
> + default:
> + return "Unknown";
> + }
> +}

Run scripts/checkpatch.pl:

ERROR: switch and case should be at the same indent
#28: FILE: drivers/iommu/iommu.c:102:
+ switch (t) {
+ case IOMMU_DOMAIN_BLOCKED:
[...]
+ case IOMMU_DOMAIN_IDENTITY:
[...]
+ case IOMMU_DOMAIN_UNMANAGED:
[...]
+ case IOMMU_DOMAIN_DMA:
[...]
+ default:

Best regards,
Lu Baolu

> +
> +static int __init iommu_subsys_init(void)
> +{
> + pr_info("Default domain type: %s\n",
> + iommu_domain_type_str(iommu_def_domain_type));
> +
> + return 0;
> +}
> +subsys_initcall(iommu_subsys_init);
> +
> int iommu_device_register(struct iommu_device *iommu)
> {
> spin_lock(&iommu_device_lock);
> list_add_tail(&iommu->list, &iommu_device_list);
> spin_unlock(&iommu_device_lock);
> -
> return 0;
> }
>
>

\
 
 \ /
  Last update: 2019-08-15 07:07    [W:1.204 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site