lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 03/28] x86/asm: annotate relocate_kernel
On Thu, Aug 08, 2019 at 12:38:29PM +0200, Jiri Slaby wrote:
> There are functions in relocate_kernel which are not annotated. This
^
_{32,64}.c

> makes automatic annotations rather hard. So annotate all the functions
> now.
>
> Note that these are not C-like functions, so we do not use FUNC, but
> CODE markers. Also they are not aligned, so we use the NOALIGN versions:
> - SYM_CODE_START_NOALIGN
> - SYM_CODE_START_LOCAL_NOALIGN
> - SYM_CODE_END
>
> In return, we get:
> 0000 108 NOTYPE GLOBAL DEFAULT 1 relocate_kernel
> 006c 165 NOTYPE LOCAL DEFAULT 1 identity_mapped
> 0146 127 NOTYPE LOCAL DEFAULT 1 swap_pages
> 0111 53 NOTYPE LOCAL DEFAULT 1 virtual_mapped

It would be cool if those NOTYPE objects could be marked as OS-specific:

From /usr/include/elf.h:

#define STT_LOOS 10 /* Start of OS-specific */

to denote that they're special but gas doesn't seem to support that type
out of the box at least.

Oh well...

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

\
 
 \ /
  Last update: 2019-08-15 10:37    [W:0.125 / U:2.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site