Messages in this thread | | | From | 啟原黃 <> | Date | Thu, 15 Aug 2019 16:04:35 +0800 | Subject | Re: [PATCH] From: cy_huang <> Subject: usb: add more vendor defined ops in tcpci |
| |
Greg KH <gregkh@linuxfoundation.org> 於 2019年8月15日 週四 下午3:14寫道: > > On Thu, Aug 15, 2019 at 12:19:13PM +0800, cy_huang wrote: > > diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h > > index 303ebde..a6754fb 100644 > > --- a/drivers/usb/typec/tcpm/tcpci.h > > +++ b/drivers/usb/typec/tcpm/tcpci.h > > @@ -130,6 +130,11 @@ struct tcpci_data { > > bool enable); > > int (*start_drp_toggling)(struct tcpci *tcpci, struct tcpci_data *data, > > enum typec_cc_status cc); > > + int (*set_vbus)(struct tcpci *tcpci, > > + struct tcpci_data *data, bool source, bool sink); > > + int (*get_current_limit)(struct tcpci *tcpci, struct tcpci_data *data); > > + int (*set_current_limit)(struct tcpci *tcpci, > > + struct tcpci_data *data, u32 max_ma, u32 mv); > > }; > > You are adding callbacks here with no users of them, which isn't > allowed. Please also submit the code that uses these callbacks at the > same time so we can review it all together. > > thanks, > > greg k-h
Yes, I'm adding the callback for the sub-pmic (CHG/TCPC)
I'll push the mfd driver first. for the tcpc, it's just a sub device.
| |