Messages in this thread | | | From | Jason Gunthorpe <> | Subject | Re: [PATCH 04/15] mm: remove the pgmap field from struct hmm_vma_walk | Date | Fri, 16 Aug 2019 00:43:07 +0000 |
| |
On Thu, Aug 15, 2019 at 04:51:33PM -0400, Jerome Glisse wrote:
> struct page. In this case any way we can update the > nouveau_dmem_page() to check that page page->pgmap == the > expected pgmap.
I was also wondering if that is a problem.. just blindly doing a container_of on the page->pgmap does seem like it assumes that only this driver is using DEVICE_PRIVATE.
It seems like something missing in hmm_range_fault, it should be told what DEVICE_PRIVATE is acceptable to trigger HMM_PFN_DEVICE_PRIVATE and fault all others?
Jason
| |