Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 16 Aug 2019 00:59:34 +0200 | Subject | Re: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang |
| |
On Thu, Aug 15, 2019 at 10:45 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > I am still not a huge fan of the CONFIG_CC_IS_CLANG ifdefs but I don't > really see a much cleaner way to get around this. Some that come to > mind:
Yeah...
> * Revert commit bfd77145f35c ("Makefile: Convert -Wimplicit-fallthrough=3 > to just -Wimplicit-fallthrough for clang") for the time being and just > rely on adding -Wimplicit-fallthrough to KCFLAGS for testing.
I would avoid applying commits that will have to be reverted just for Clang, particularly since it is not fully supported yet.
Cheers, Miguel
| |