Messages in this thread | | | Date | Wed, 14 Aug 2019 08:17:17 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH] ARM: dts: sunxi: Add mdio bus sub-node to GMAC |
| |
On Wed, Aug 14, 2019 at 12:22:08PM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The DWMAC binding never supported having the Ethernet PHY node as a > direct child to the controller, nor did it support the "phy" property > as a way to specify which Ethernet PHY to use. What seemed to work > was simply the implementation ignoring the "phy" property and instead > probing all addresses on the MDIO bus and using the first available > one. > > The recent switch from "phy" to "phy-handle" breaks the assumptions > of the implementation, and does not match what the binding requires. > The binding requires that if an MDIO bus is described, it shall be > a sub-node with the "snps,dwmac-mdio" compatible string. > > Add a device node for the MDIO bus, and move the Ethernet PHY node > under it. Also fix up the #address-cells and #size-cells properties > where needed. > > Fixes: de332de26d19 ("ARM: dts: sunxi: Switch from phy to phy-handle") > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied, thanks! Maxime
-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |