lkml.org 
[lkml]   [2019]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] waitid: Add support for waiting for the current process group
On 08/14, Christian Brauner wrote:
>
> +static struct pid *find_get_pgrp(pid_t nr)
> +{
> + struct pid *pid;
> +
> + if (nr)
> + return find_get_pid(nr);
> +
> + rcu_read_lock();
> + pid = get_pid(task_pgrp(current));
> + rcu_read_unlock();
> +
> + return pid;
> +}

I can't say I like this helper... even its name doesn't look good to me.

I forgot that we already have get_task_pid() when I replied to the previous
version... How about

case P_PGID:

if (upid)
pid = find_get_pid(upid);
else
pid = get_task_pid(current, PIDTYPE_PGID);

?

Oleg.

\
 
 \ /
  Last update: 2019-08-14 16:20    [W:0.030 / U:6.196 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site