lkml.org 
[lkml]   [2019]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] i2c: axxia: support slave mode
Hi Krzysztof,

> - Reduced the number of dev_dbg messages.

Yes, that looks good. Just some curly braces left over...

> + if (fifo_status & SLV_FIFO_STRC) {
> + i2c_slave_event(idev->slave,
> + I2C_SLAVE_WRITE_REQUESTED, &val);
> + }

...

> + if (fifo_status & SLV_FIFO_RSC) {
> + readl(idev->base + SLV_DATA); /* dummy read */
> + }

..

> + if (status & SLV_STATUS_SRC1) {
> + i2c_slave_event(idev->slave, I2C_SLAVE_STOP, &val);
> + }

If you add '--strict' to checkpatch, it warns about two of them.

Kind regards,

Wolfram

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-08-14 15:14    [W:0.029 / U:74.756 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site