Messages in this thread | | | Date | Wed, 14 Aug 2019 10:08:56 +0100 | From | Mark Brown <> | Subject | Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream() |
| |
On Wed, Aug 14, 2019 at 09:41:42AM +0530, Vinod Koul wrote: > On 13-08-19, 20:58, Mark Brown wrote:
> > There is something to be said for not abusing the TDM slot API if it can > > make things clearer by using bus-idiomatic mechanisms, but it does mean > > everything needs to know about each individual bus :/ .
> Here ASoC doesn't need to know about sdw bus. As Srini explained, this > helps in the case for him to get the stream context and set the stream > context from the machine driver.
Other drivers interoperating with the Soundwire DAI might want to do something, it looks like that's the case for SOF.
> Nothing else is expected to be done from this API. We already do a set > using snd_soc_dai_set_sdw_stream(). Here we add the snd_soc_dai_get_sdw_stream() to query
Well, if the API is not expected to do anything we can optimize it and just remove it! [unhandled content-type:application/pgp-signature] | |