lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 4/5] PTP: Add flag for non-periodic output
    On Tue, Aug 13, 2019 at 10:48:21AM -0700, Richard Cochran wrote:
    > > + if (copy_from_user(&req.extts, (void __user *)arg,
    > > + sizeof(req.extts))) {
    > > + err = -EFAULT;
    > > + break;
    > > + }
    > > + if (req.extts.flags || req.extts.rsv[0]
    > > + || req.extts.rsv[1]) {
    > > + err = -EINVAL;
    >
    > Since the code is mostly the same as in the PTP_EXTTS_REQUEST case,
    > maybe just double up the case statements (like in the other) and add
    > an extra test for (cmd == PTP_EXTTS_REQUEST2) for this if-block.

    Thinking about the drivers, in the case of the legacy ioctls, let's
    also be sure to clear the flags and reserved fields before passing
    them to the drivers.

    Thanks,
    Richard

    \
     
     \ /
      Last update: 2019-08-13 20:07    [W:4.878 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site