Messages in this thread | | | Subject | Re: [RFC PATCH v2 15/19] mm/gup: Introduce vaddr_pin_pages() | From | John Hubbard <> | Date | Tue, 13 Aug 2019 10:56:51 -0700 |
| |
On 8/13/19 10:46 AM, Ira Weiny wrote: > On Tue, Aug 13, 2019 at 08:47:06AM -0300, Jason Gunthorpe wrote: >> On Mon, Aug 12, 2019 at 02:48:55PM -0700, Ira Weiny wrote: >>> On Mon, Aug 12, 2019 at 09:28:14AM -0300, Jason Gunthorpe wrote: >>>> On Fri, Aug 09, 2019 at 03:58:29PM -0700, ira.weiny@intel.com wrote: >>>>> From: Ira Weiny <ira.weiny@intel.com> ... >>> So I'm open to suggestions. Jan gave me this one, so I figured it was safer to >>> suggest it... >> >> Should have the word user in it, imho > > Fair enough... > > user_addr_pin_pages(void __user * addr, ...) ? > > uaddr_pin_pages(void __user * addr, ...) ? > > I think I like uaddr... >
Better to spell out "user". "u" prefixes are used for "unsigned" and it is just too ambiguous here. Maybe:
vaddr_pin_user_pages()
...which also sounds close enough to get_user_pages() that a bit of history and continuity is preserved, too.
thanks, -- John Hubbard NVIDIA
| |