lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v4 0/7] x86: KVM: svm: get rid of hardcoded instructions lengths
Date
Changes since v3 [Sean Christopherson]:
- add Reviewed-by tag to PATCH5
- __skip_emulated_instruction()/skip_emulated_instruction() split,
'unlikely(r != EMULATE_DONE)' in PATCH2
- Make nested_svm_vmrun() return an int in PATCH6 (moved from PATCH7)
- Avoid weird-looking 'if (rc) return ret' in PATCH7

Original description:

Jim rightfully complains that hardcoding instuctions lengths is not always
correct: additional (redundant) prefixes can be used. Luckily, the ugliness
is mostly harmless: modern AMD CPUs support NRIP_SAVE feature but I'd like
to clean things up and sacrifice speed in favor of correctness.

Vitaly Kuznetsov (7):
x86: KVM: svm: don't pretend to advance RIP in case
wrmsr_interception() results in #GP
x86: kvm: svm: propagate errors from skip_emulated_instruction()
x86: KVM: clear interrupt shadow on EMULTYPE_SKIP
x86: KVM: add xsetbv to the emulator
x86: KVM: svm: remove hardcoded instruction length from intercepts
x86: KVM: svm: eliminate weird goto from vmrun_interception()
x86: KVM: svm: eliminate hardcoded RIP advancement from
vmrun_interception()

arch/x86/include/asm/kvm_emulate.h | 3 +-
arch/x86/include/asm/kvm_host.h | 2 +-
arch/x86/kvm/emulate.c | 23 ++++++-
arch/x86/kvm/svm.c | 100 +++++++++++++----------------
arch/x86/kvm/vmx/vmx.c | 16 ++++-
arch/x86/kvm/x86.c | 13 +++-
6 files changed, 92 insertions(+), 65 deletions(-)

--
2.20.1

\
 
 \ /
  Last update: 2019-08-13 15:54    [W:0.122 / U:13.220 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site