lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: OMAP: dma: Mark expected switch fall-throughs
* Kees Cook <keescook@chromium.org> [190729 16:35]:
> On Sun, Jul 28, 2019 at 06:22:40PM -0500, Gustavo A. R. Silva wrote:
> > Mark switch cases where we are expecting to fall through.
> >
> > This patch fixes the following warnings:
> >
> > arch/arm/plat-omap/dma.c: In function 'omap_set_dma_src_burst_mode':
> > arch/arm/plat-omap/dma.c:384:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > if (dma_omap2plus()) {
> > ^
> > arch/arm/plat-omap/dma.c:393:2: note: here
> > case OMAP_DMA_DATA_BURST_16:
> > ^~~~
> > arch/arm/plat-omap/dma.c:394:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > if (dma_omap2plus()) {
> > ^
> > arch/arm/plat-omap/dma.c:402:2: note: here
> > default:
> > ^~~~~~~
> > arch/arm/plat-omap/dma.c: In function 'omap_set_dma_dest_burst_mode':
> > arch/arm/plat-omap/dma.c:473:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> > if (dma_omap2plus()) {
> > ^
> > arch/arm/plat-omap/dma.c:481:2: note: here
> > default:
> > ^~~~~~~
> >
> > Notice that, in this particular case, the code comment is
> > modified in accordance with what GCC is expecting to find.
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Applying into fixes thanks.

Tony

\
 
 \ /
  Last update: 2019-08-13 14:01    [W:0.039 / U:5.440 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site