[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] net: gmii2rgmii: Switch priv field in mdio device structure
Hi Andrew,

On Thu, Aug 1, 2019 at 9:36 AM Andrew Lunn <> wrote:
> On Wed, Jul 31, 2019 at 03:06:19PM +0530, Harini Katakam wrote:
> > Use the priv field in mdio device structure instead of the one in
> > phy device structure. The phy device priv field may be used by the
> > external phy driver and should not be overwritten.
> Hi Harini
> I _think_ you could use dev_set_drvdata(&mdiodev->dev) in xgmiitorgmii_probe() and
> dev_get_drvdata(&phydev-> in _read_status()

Thanks for the review. This works if I do:
dev_set_drvdata(&priv->phy_dev->>dev) in probe
and then
dev_get_drvdata(&phydev-> in _read_status()

i.e mdiodev in gmii2rgmii probe and priv->phy_dev->mdio are not the same.

If this is acceptable, I can send a v2.


 \ /
  Last update: 2019-08-13 13:17    [W:0.059 / U:49.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site